Apply item mods to across modules #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pablete1234
requested changes
Oct 31, 2021
Pugzy
force-pushed
the
item-mod-fixes
branch
2 times, most recently
from
656d99f to
8b2d343
Compare
Signed-off-by: Pugzy <[email protected]>
Pablete1234
approved these changes
Nov 4, 2021
Electroid
reviewed
Nov 6, 2021
Comment on lines
+68
to
+69
| final ItemStack itemStack = factory.getKits().parseItem(itemEl, false); | ||
| itemModifier.ifPresent(imm -> imm.applyRules(itemStack)); |
There was a problem hiding this comment.
If the goal of ItemModifyModule is to ensure that all ItemStacks are modified to certain rules, I would think that parseItem should return the already modified item? The problem here is that the caller has to remember to call applyRules, which would be quite easy to forget.
There was a problem hiding this comment.
Original pgm did it like this and i don't know why, but something tells me it's better not to.
I feel there may be use-cases for parseItem that don't require itemmodding
Electroid
approved these changes
Nov 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Issue
Maps that use item mods can cause items (typically arrows and gapples) to be non-stackable.
If the item mod is applied to the items in the player's inventory but not on items picked up or given to them they will not stack.
Background on Item Mods
Item mods work by checking all items to see if modifications are required, once checked all items are marked with meta (in the current case hidden lore). Items that are not checked and are received by a player are missing this extra data so the items do not match.
The Solution(s)
There are a few elements fixed/changed to make this function as expected.
ToolRepairMatchModuleso items don't just disappear but look to be picked up (with the animation and world sound unlike before).Thanks to @Pablete1234 and @PabloPintor for debugging and testing.
Signed-off-by: Pugzy [email protected]